Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pki-server <subsystem>-db-repl-enable #4639

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Dec 13, 2023

The pki-server <subsystem>-db-repl-enable has been added to enable replication on a single DS instance. This command replaces the SubsystemDBReplicationSetupCLI which enables replication both on the DS master and the replica at the same time.

The test for CA cloning with replicated DS has been updated to use the new command.

https://github.com/dogtagpki/389-ds-base/wiki/Configuring-DS-Replication-with-PKI-Tools

Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have a very small comment but feel free to merge as it is.

--replica-id=1 \
--bind-dn="cn=Replication Manager,cn=config" \
--bind-passwd=Secret.123
docker exec secondary pki-server ca-db-repl-enable \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result should be the same but I would prefer to enable replication on primary DS from the primary instance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was originally trying to mimic how these commands are executed by pkispawn (i.e. always from the secondary server), but I think that scenario has been tested by the regular CA cloning test, so in this test we can run the commands from the primary server.

The pki-server <subsystem>-db-repl-enable has been added
to enable replication on a single DS instance. This command
replaces the SubsystemDBReplicationSetupCLI which enables
replication both on the DS master and the replica at the
same time.

The test for CA cloning with replicated DS has been updated
to use the new command.
@edewata
Copy link
Contributor Author

edewata commented Dec 14, 2023

@fmarco76 Thanks! I've updated the PR as you suggested. I'll merge once the CI completes.

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
0.0% Coverage on New Code
19.3% Duplication on New Code

See analysis details on SonarCloud

@edewata edewata merged commit a9e002f into dogtagpki:master Dec 14, 2023
130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants