Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pki-server <subsystem>-db-index-add/rebuild #4627

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Nov 28, 2023

The code that adds and rebuilds DS database search indexes in SubsystemDBInitCLI has been moved into SubsystemDBIndexAddCLI and SubsystemDBIndexRebuildCLI, respectively, such that they can be used more independently.

Similarly, the PKISubsystem.init_database() has been split into add_indexes() and rebuild_indexes().

The pki-server <subsystem>-db-index-add/rebuild commands have been added to execute these operations from command line.

The test for installing CA with existing DS has been updated to use the new commands.

https://github.com/dogtagpki/pki/wiki/Setting-up-CA-Database

@edewata edewata requested a review from fmarco76 November 28, 2023 23:37
@edewata edewata force-pushed the cli branch 2 times, most recently from 2d35cf1 to e22e3d5 Compare November 28, 2023 23:49
Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The code that adds and rebuilds DS database search indexes in
SubsystemDBInitCLI has been moved into SubsystemDBIndexAddCLI
and SubsystemDBIndexRebuildCLI, respectively, such that they
can be used more independently.

Similarly, the PKISubsystem.init_database() has been split
into add_indexes() and rebuild_indexes().

The pki-server <subsystem>-db-index-add/rebuild commands have
been added to execute these operations from command line.

The test for installing CA with existing DS has been updated
to use the new commands.
@edewata
Copy link
Contributor Author

edewata commented Nov 29, 2023

@fmarco76 Thanks! I updated the commit message. I'll merge after the CI completes.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
32.9% 32.9% Duplication

@edewata edewata merged commit 93c666e into dogtagpki:master Nov 30, 2023
132 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants