Restore support for cert bundle in pki_cert_chain_path #4616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmarco76
approved these changes
Nov 17, 2023
The NSSDatabase.import_cert_chain() has been modified to support importing cert bundle by converting it into a PKCS dogtagpki#7 file, then import it using the existing code. The test for installing KRA on a separate instance has been modified to use a root CA and a sub CA, then use a cert bundle in the pki_cert_chain_path param. The NSSCertImportCLI has been updated to avoid an NPE if the nickname is not specified. https://bugzilla.redhat.com/show_bug.cgi?id=2250162
|
@fmarco76 Thanks! I'll merge after the CI completes. |
|
Just FYI, I tried to set up a similar test using PKCS #7 cert chain instead of cert bundle and it did not work. It looks like either the Python SSL library or Python Requests doesn't work with PKCS #7 cert chain, or maybe the PKI code doesn't set it up correctly. It will require further investigation. |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NSSDatabase.import_cert_chain()has been modified to support importing cert bundle by converting it into a PKCS #7 file, then import it using the existing code.The test for installing KRA on a separate instance has been modified to use a root CA and a sub CA, then use a cert bundle in the
pki_cert_chain_pathparam.The
NSSCertImportCLIhas been updated to avoid an NPE if the nickname is not specified.https://bugzilla.redhat.com/show_bug.cgi?id=2250162