Bug 2246422 ServerSideKeygen static SKID #4597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch intends to address the bug where in the case of ServerSide keygen, a static SKI extension was injected as a result. fixes https://bugzilla.redhat.com/show_bug.cgi?id=2246422
jmagne
approved these changes
Nov 1, 2023
| addExtension(name, ext, info); | ||
| } | ||
|
|
||
| public static Extension getExtension(String name, X509CertInfo info) { |
There was a problem hiding this comment.
Just a comment here on the returning of null if the input is not valid. I guess here the caller can't distinguish whether or not the the extension was not present or that the input was bad. Would it make sense to throw an exception in the bad input case?
|
|
||
| logger.debug("EnrollDefault: Searching for " + name + " extension"); | ||
|
|
||
| if (exts == null) { |
There was a problem hiding this comment.
Same as above about the input.
|
|
||
| if (isSSKeygen) { | ||
| try { | ||
| String pubKeyStr = request.getExtDataInString("public_key"); | ||
| if (pubKeyStr == null) { | ||
| throw new EProfileException("Server-Side Keygen enrollment failed to retrieve public_key from KRA"); | ||
| } | ||
| //logger.debug(method + "pubKeyStr = " + pubKeyStr); | ||
| logger.debug(method + "pubKeyStr = " + pubKeyStr); |
There was a problem hiding this comment.
Did we comment out this debug value for a reason?
|
Based on the need for a scratch build and some successful internal testing, I will check this thing in myself, so the build can take place with this fix. |
ladycfu
added a commit
that referenced
this pull request
Nov 16, 2023
This patch intends to address the bug where in the case of ServerSide keygen, a static SKI extension was injected as a result. fixes https://bugzilla.redhat.com/show_bug.cgi?id=2246422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch intends to address the bug where in the case of ServerSide keygen, a static SKI extension was injected as a result.
fixes https://bugzilla.redhat.com/show_bug.cgi?id=2246422