Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cert validity options/params for CLI and ACME #4592

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Oct 18, 2023

The pki nss-cert-issue command and the NSSIssuer in ACME have been modified to provide options/params to specify the cert validity in different units (e.g. minutes) which could be useful for testing and end-users as well.

The old option/param is limited to months only so it has been deprecated.

https://github.com/edewata/pki/blob/cli/docs/changes/v11.5.0/Server-Changes.adoc
https://github.com/edewata/pki/blob/cli/docs/changes/v11.5.0/Tools-Changes.adoc

@edewata edewata requested a review from fmarco76 October 18, 2023 17:46
Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The pki nss-cert-issue command and the NSSIssuer in ACME have
been modified to provide options/params to specify the cert
validity in different units (e.g. minutes) which could be
useful for testing and end-users as well.

The old option/param is limited to months only so it has been
deprecated.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

0.0% 0.0% Coverage
8.3% 8.3% Duplication

@edewata
Copy link
Contributor Author

edewata commented Oct 19, 2023

@fmarco76 Thanks! I updated pki-ca-run and pki-server-run to use 1 year validity as well.

@edewata edewata merged commit f8aecf2 into dogtagpki:master Oct 19, 2023
129 of 130 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants