Remove CMSEngine dependency in LdapConnFactory #4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LdapConnFactory has been modified to no longer dependent on CMSEngine. Instead, the CMSEngine will provide methods to create an LDAP connection factory that is already configured with the engine's auditor, socket listener, and cert approval callback. All code that were calling LdapConnFactory.setCMSEngine() has been modified to call the new methods, except for DBSubsystem and UGSubsystem since they are also used by CLIs which do not have a CMSEngine instance. These changes will eventually allow LdapConnFactory to be used outside of PKI server environment.
|
@ckelleyRH @fmarco76 Thanks! |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LdapConnFactoryhas been modified to no longer dependent onCMSEngine. Instead, theCMSEnginewill provide methods to create an LDAP connection factory that is already configured with the engine's auditor, socket listener, and cert approval callback.All code that were calling
LdapConnFactory.setCMSEngine()has been modified to call the new methods, except forDBSubsystemandUGSubsystemsince they are also used by CLIs which do not have aCMSEngineinstance.These changes will eventually allow
LdapConnFactoryto be used outside of PKI server environment.