Drop SHA-1 fingerprints #3824
Drop SHA-1 fingerprints #3824
Conversation
There was a problem hiding this comment.
I think the time has come to un-defer this.
There are a few places where I think renewed examples in the javadoc would help.
Also, can we lose MD2 and MD5 at the same time and maybe add in SHA-384 fingerprints? I don't know what the consequences of doing this in the C code are. Are they conforming to some external expectations for algorithms or can we drop MD2/MD5; add SHA-384 there too?
| @@ -1853,7 +1853,7 @@ public Hashtable<String, byte[]> makeFingerPrints(CRSPKIMessage req) { | |||
| Hashtable<String, byte[]> fingerprints = new Hashtable<>(); | |||
|
|
|||
| MessageDigest md; | |||
| String[] hashes = new String[] { "MD2", "MD5", "SHA1", "SHA256", "SHA512" }; | |||
There was a problem hiding this comment.
Drop MD2/MD5, add SHA-384?
| * MD5, MD2 and SHA1 hashes. | ||
| * MD5 and MD2 hashes. |
There was a problem hiding this comment.
Drop MD2/MD5, add SHA-384?
| * @return a String with fingerprints using the MD5, MD2 and SHA1 hashes. | ||
| * @return a String with fingerprints using the MD5 and MD2 hashes. |
There was a problem hiding this comment.
Drop MD2/MD5, add SHA-384?
| * MD2: 78:7E:D1:F9:3E:AF:50:18:68:A7:29:50:C3:21:1F:71 | ||
| * | ||
| * MD5: 0E:89:91:AC:40:50:F7:BE:6E:7B:39:4F:56:73:75:75 | ||
| * | ||
| * SHA1: DC:D9:F7:AF:E2:83:10:B2:F7:0A:77:E8:50:E2:F7:D1:15:9A:9D:00 |
There was a problem hiding this comment.
Make a new example with SHA-256, SHA-384 and SHA-512?
| String[] hashes = new String[] {"MD2", "MD5", "SHA1"}; | ||
| String[] hashes = new String[] {"MD2", "MD5"}; |
There was a problem hiding this comment.
Drop MD2/MD5, add SHA-256, SHA-384 and SHA-512?
| * MD2: 78:7E:D1:F9:3E:AF:50:18:68:A7:29:50:C3:21:1F:71 | ||
| * | ||
| * MD5: 0E:89:91:AC:40:50:F7:BE:6E:7B:39:4F:56:73:75:75 | ||
| * | ||
| * SHA1: DC:D9:F7:AF:E2:83:10:B2:F7:0A:77:E8:50:E2:F7:D1:15:9A:9D:00 |
There was a problem hiding this comment.
Make a new example with SHA-256, SHA-384 and SHA-512?
| * MD5, MD2 and SHA1 hashes. | ||
| * MD5 and MD2 hashes. |
There was a problem hiding this comment.
Drop MD2/MD5, add SHA-256, SHA-384 and SHA-512?
| * @return a String with fingerprints using the MD5, MD2 and SHA1 hashes. | ||
| * @return a String with fingerprints using the MD5 and MD2 hashes. |
There was a problem hiding this comment.
Drop MD2/MD5, add SHA-256, SHA-384 and SHA-512?
| String[] hashes = new String[] { "MD2", "MD5", "SHA1", "SHA256", "SHA512" }; | ||
| String[] hashes = new String[] { "MD2", "MD5", "SHA256", "SHA512" }; |
There was a problem hiding this comment.
Drop MD2/MD5, add SHA-256, SHA-384 and SHA-512?
|
I started commenting on individual lines before I realised that I could probably just summarise in a few lines, there are still some "unmarked" places where I didn't leave comments. |
|
@ckelleyRH Thanks for your comments! |
|
I'd have to defer to @ladycfu. |
|
@edewata shall we close this? |
|
Let's check with @ladycfu. |
No description provided.