-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Java dependencies #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Feel free to merge if this avoid problems with java versions.
However I think we should keep the java requirements. We could have something like:
Requires: java_headless >= 17
just to avoid version before 17.
We could even avoid this version and require only java_headless
since it is associated to java 17 for both F39 and F40, until this will move to java 21.
Sorry, this is not quite ready yet. It needs additional testing. |
One of the issues is java-17-openjdk-headless apparently doesn't provide |
Not sure on this. In F39 I have:
With F40 we have:
In both cases I see |
Hmm.. interesting. Thanks for investigating! This is how it's defined in Fedora: |
Not sure for java_devel. In F40 is this java 21 I guess. Are we ready to move to this version? Do we need to test it? |
The RPM spec has been updated to use Java 21 on Fedora 40 or later and Java 17 on other platforms. The Dockerfile has been modified to remove any Java packages pulled by the existing LDAP SDK package to ensure that the build will be done using the correct Java version. The tools-test.sh has been updated to remove hard-coded JAVA_HOME.
Quality Gate passedIssues Measures |
This is ready now. Please see the updated PR. We'll use Java 21 on Fedora 40+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fmarco76 Thanks! |
The RPM spec has been updated to use Java 21 on Fedora 40 or later and Java 17 on other platforms.
The
Dockerfile
has been modified to remove any Java packages pulled by the existing LDAP SDK package to ensure that the build will be done using the correct Java version.The
tools-test.sh
has been updated to remove hard-codedJAVA_HOME
.