Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused method JSS_NSS_getEventArrayList() #1026

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

fmarco76
Copy link
Member

The method was used to get SSLSoecketEvent but the mechanism has been modified in the following commit and this is method is not used.

Update SSLFDProxy to implement SSLSocketListener (0f352ec)

The problem has been identified and reported as side effect of PR #1024 by @siteshwar

The method was used to get SSLSoecketEvent but the mechanism has been
modified in the following commit and this is method is not used.

Update SSLFDProxy to implement SSLSocketListener (0f352ec)
@fmarco76 fmarco76 requested a review from edewata October 14, 2024 18:03
Copy link

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmarco76
Copy link
Member Author

@edewata @siteshwar Thanks!

@fmarco76 fmarco76 merged commit fa69663 into dogtagpki:master Oct 15, 2024
32 of 35 checks passed
@fmarco76 fmarco76 deleted the removeArrayEvent branch October 15, 2024 08:50
@siteshwar
Copy link

If you may be interested in full list of findings from OpenScanHub, they can be seen through https://openscanhub.fedoraproject.org/task/9062/log/jss-5.6.0-0.20240903212537552344.pr1025.70.g73a48869/scan-results.html.

Alternatively, please review osh-diff-scan job for each pull request. For example https://github.com/dogtagpki/jss/pull/1022/checks?check_run_id=29079267242.

Thank you for looking into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants