Update JSSTrustManager to support trusted peers #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSSTrustManager has been updated to mimic NSS cert validation which supports trusted peers. The checkCertChain() has been modified to check whether the cert chain has P,, trust flags, and if that's the case the cert chain is considered trusted so it's not necessary to check the cert issuer anymore.
|
|
@fmarco76 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSSTrustManagerhas been updated to mimic NSS cert validation which supports trusted peers. ThecheckCertChain()has been modified to check whether the cert chain hasP,,trust flags, and if that's the case the cert chain is considered trusted so it's not necessary to check the cert issuer anymore.