Fix test 17 error on build #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the nss update to >= 3.101 the nss context gets initialised after the CryptoManager instance is retrieved so this step is added before the test. Additional, the ssl option test for get and set has been modified to enable/disable ssl cache since the ssl3 option is policy dependent and do not always work.
|
edewata
approved these changes
Jun 25, 2024
|
@edewata Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the nss update to >= 3.101 the nss context gets initialised after the CryptoManager instance is retrieved so this step is added before the test.
The original error was in this NSS line: https://github.com/nss-dev/nss/blob/4b0cca5ba45b3713e279f9d528dfa01dd886cea8/lib/nss/nssinit.c#L1002
All the other tests were working because the use of the CryptoManager before performing and operation involving NSS.
Additionally, the ssl option test for get and set has been modified to enable/disable ssl cache since the ssl3 option is policy dependent and do not always work.
Fix #1010
Note about the options: running the test with NSS released on fedora using SSL3 option was not working but using my build (I have included debug options) the test works. Looking at the code SSL3 cannot be enabled if it is not supported by the policy: https://github.com/nss-dev/nss/blob/4b0cca5ba45b3713e279f9d528dfa01dd886cea8/lib/ssl/sslsock.c#L629. Therefore I have just used a different option since the test was just to verify that option can be configured and it was not related to ssl3. We can investigate more if needed.