Skip to content

Commit

Permalink
Include certificate information in SSL session
Browse files Browse the repository at this point in the history
Certificates are included in the SSL session also in case of handshake
failure. If certificate are not available there are no exception and or
error reported beside the one creating the failure.

Certificate information are needed in case of event audits.
  • Loading branch information
fmarco76 committed May 21, 2024
1 parent 945cb06 commit 3a4ffcc
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,6 @@ private SSLException checkSSLAlerts() {

private void updateHandshakeState() {
debug("JSSEngine: updateHandshakeState()");

// If we've previously seen an exception, we should just return
// here; there's already an alert on the wire, so there's no point
// in checking for new ones and/or stepping the handshake: it has
Expand Down Expand Up @@ -1054,6 +1053,11 @@ private void updateHandshakeState() {
if (SSL.ForceHandshake(ssl_fd) == SSL.SECFailure) {
int error_value = PR.GetError();

try {
PK11Cert[] peer_chain = SSL.PeerCertificateChain(ssl_fd);
session.setPeerCertificates(peer_chain);
} catch (Exception e) {}

if (error_value != PRErrors.WOULD_BLOCK_ERROR) {
debug("JSSEngine.updateHandshakeState() - FATAL " + getStatus());

Expand Down

0 comments on commit 3a4ffcc

Please sign in to comment.