Improve oslUnswizzleTexture and oslUnswizzleImage functions #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enhanced variable naming for better code clarity and readability. - Added error handling for memory allocation in oslUnswizzleImage. - Used malloc to allocate memory safely for the temporary buffer. - Refined platform-specific code with clearer intent for non-PSP platforms. - Maintained optimized loop structure for texture unswizzling on PSP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the
oslUnswizzleTextureandoslUnswizzleImagefunctions by enhancing code clarity, memory management, and platform-specific handling.Key Changes:
oslUnswizzleImage.These changes enhance the maintainability and robustness of the code without altering its existing functionality.