Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor image conversion and palette search functions for clarity and efficiency #53

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

dogo
Copy link
Owner

@dogo dogo commented Sep 2, 2024

Summary

This PR refactors the image conversion and palette search functions in oslib for better readability and maintainability.

Key Changes

  • Improved variable naming for clarity.
  • Added comments to explain key sections of the code.
  • Introduced early return for better error handling during image creation.
  • Refactored loops and conditionals for more readable code.
  • Ensured proper cleanup of resources after image conversion.

Impact

  • No changes to existing functionality.
  • Code is now easier to understand and maintain.

…d efficiency

- Improved variable naming for better readability and consistency.
- Added detailed comments to clarify the purpose and functionality of the code.
- Introduced early return to handle potential failure during image creation.
- Refined the structure of loops and conditionals for better maintainability.
- Ensured proper cleanup of original image and cache after conversion.
@dogo dogo merged commit ae4fec8 into master Sep 2, 2024
6 checks passed
@dogo dogo deleted the refactor/oslConvertImageTo branch September 2, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant