Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-6341: Add Metrics type icons in versions tab #2048

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test
hyunnaye committed Dec 5, 2024
commit e5ca52cc0a7cd66ffa69caf420f1607e862e4099
4 changes: 4 additions & 0 deletions cypress/e2e/group3/metrics.ts
Original file line number Diff line number Diff line change
@@ -22,6 +22,10 @@ describe('Dockstore Metrics', () => {
}).as('getMetrics');
});
cy.visit('/workflows/github.com/A/l:master');
goToTab('Versions');
cy.get('[data-cy=execution-metrics-icon]').should('be.visible');
cy.get('[data-cy=validation-metrics-icon]').should('be.visible');

cy.wait('@getMetrics');
goToTab('Metrics');

2 changes: 2 additions & 0 deletions src/app/workflow/workflow.component.html
Original file line number Diff line number Diff line change
@@ -525,12 +525,14 @@ <h3>
*ngIf="hasExecutionMetrics"
src="assets/svg/manufacturing.svg"
hyunnaye marked this conversation as resolved.
Show resolved Hide resolved
alt="Execution Metrics Icon"
data-cy="execution-metrics-icon"
matTooltip="This version contains execution metrics."
/>
<img
*ngIf="hasValidationMetrics"
src="assets/svg/data_check.svg"
hyunnaye marked this conversation as resolved.
Show resolved Hide resolved
alt="Validation Metrics Icon"
data-cy="validation-metrics-icon"
matTooltip="This version contains validation metrics."
/>
</div>