Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 159 update requiremnts to specify working versions #160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tjohnson-somalogic
Copy link

@tjohnson-somalogic tjohnson-somalogic commented Jun 5, 2024

Fixes #159

@@ -2,7 +2,7 @@
from langchain_openai import OpenAIEmbeddings
from langchain_community.embeddings import OllamaEmbeddings
from langchain_community.embeddings import BedrockEmbeddings
from langchain_community.embeddings.sentence_transformer import SentenceTransformerEmbeddings
from langchain_community.embeddings.huggingface import HuggingFaceEmbeddings

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from langchain_community.embeddings.huggingface import HuggingFaceEmbeddings
from langchain_community.embeddings.sentence_transformer import SentenceTransformerEmbeddings

@@ -48,7 +48,7 @@ def load_embedding_model(embedding_model_name: str, logger=BaseLogger(), config=
dimension = 768
logger.info("Embedding: Using Google Generative AI Embeddings")
else:
embeddings = SentenceTransformerEmbeddings(
embeddings = HuggingFaceEmbeddings(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
embeddings = HuggingFaceEmbeddings(
embeddings = SentenceTransformerEmbeddings(

@@ -4,7 +4,7 @@ wikipedia
tiktoken
neo4j
streamlit
sentence_transformers==2.2.2
sentence_transformers==2.6.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sentence_transformers==2.6.0
sentence_transformers

langchain-openai
langchain-community
langchain-community==0.2.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
langchain-community==0.2.1
langchain-community

Comment on lines +17 to +18
langchain-huggingface==0.0.2
langchain-core==0.2.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
langchain-huggingface==0.0.2
langchain-core==0.2.1

langchain-google-genai
# Do more of these versions need to be fixed?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Do more of these versions need to be fixed?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested on my Mac, just by removing the version on the sentence-transformers it worked on my environment, please review if this change solves it for you as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version Update needed: ValueError: alternative_import must be a fully qualified module path
2 participants