Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c8d/push: better output if single-platform is pushed from index #5574

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

laurazard
Copy link
Member

@laurazard laurazard commented Oct 25, 2024

Stacked on top of #5572

- What I did

Added a docker images --tree-style messaging to the "Not all multiplatform-content is present and only the available single-platform image was pushed" messaging during a docker push, to more clearly indicate explain what happened and which manifest was actually pushed.

Screenshot 2024-10-25 at 16 34 14

- How I did it

This requires adding information about which candidates were considered for pushing to the aux stream – moby/moby#48782.

- How to verify it

  • docker pull alpine
  • docker pull --platform [other-platform] alpine
  • docker tag alpine <my-namespace>/alpine
  • docker push <my-namespace>/alpine

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Laura Brehm <[email protected]>
@laurazard laurazard added kind/enhancement area/ux containerd-integration Issues and PRs related to containerd integration labels Oct 25, 2024
@laurazard laurazard self-assigned this Oct 25, 2024
@laurazard
Copy link
Member Author

laurazard commented Oct 25, 2024

This is a draft ⚠️ It needs cleaning up and I need to open a PR in moby to (discuss and) add the additional info to the aux output.

Signed-off-by: Laura Brehm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux containerd-integration Issues and PRs related to containerd integration kind/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant