Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/#138 ReactorKit 적용 - 북마크 #141

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Refactor/#138 ReactorKit 적용 - 북마크 #141

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1f10c53
[ADD] : ReactorKit 의존성 추가
kth1210 Mar 24, 2024
66cfc4f
[RENAME] : TypeInfo -> BookmarkTypeInfo
kth1210 Mar 27, 2024
958471e
[REFACTOR] : BookmarkVM ReactorKit - Reactor 적용
kth1210 Mar 27, 2024
d7b1335
[REFACTOR] : BookmarkVC ReactorKit - View 적용
kth1210 Mar 27, 2024
dd07db4
[CHORE] : AuthInterceptor 스레드 문제 해결
kth1210 Mar 27, 2024
5fb18f5
[REFACTOR] : BookmarkVM ReactorKit - Reactor 적용
kth1210 Mar 27, 2024
5f667a4
[REFACTOR] : BookmarkVC ReactorKit - View 적용
kth1210 Mar 27, 2024
c9c52cc
[REFACTOR] : BookmarkCardListVM ReactorKit - Reactor 적용
kth1210 Mar 27, 2024
078a1a3
[REFACTOR] : BookmarkListVC ReactorKit - View 적용
kth1210 Mar 27, 2024
21f74a6
[FEAT] : BookmarkInfo Model empty 추가
kth1210 Mar 27, 2024
08bbe18
[REFACTOR] : BookmarkBottomSheetVM ReactorKit - Reactor 적용
kth1210 Mar 27, 2024
0a89c8e
[REFACTOR] : BookmarkBottomSheetVC ReactorKit - View 적용
kth1210 Mar 27, 2024
86a5583
[CHORE] : BookmarkCardListVM private 키워드 수정
kth1210 Mar 27, 2024
384a13f
[CHORE] : 프로젝트 파일 변경 사항 반영
kth1210 Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Reet-Place/Reet-Place/Global/Network/AuthInterceptor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ final class AuthInterceptor: RequestInterceptor {
completion(.doNotRetryWithError(error))
return
}
tabBarVC.showToast(message: "LogoutSuccess".localized, bottomViewHeight: 50.0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 여기서 커밋 메시지로 작성한 스레드 문제가 뭐였나요?? 어떤 점이 문제였는지 기억이 나질 않네요😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존 AuthInterceptor에서 해당 코드를 호출할 때
메인 스레드가 아닌 다른 스레드에서 UI 작업을 시도하기 때문에 문제가 발생했습니다!
이번에 발견한 문제였어요,, 😅

myPageVC.updateLoginStatus()

print("로그인 만료")
Expand Down