-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/#138 ReactorKit 적용 - 북마크 #141
Open
kth1210
wants to merge
14
commits into
develop
Choose a base branch
from
refactor/#138-ReactorKit
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1f10c53
[ADD] : ReactorKit 의존성 추가
kth1210 66cfc4f
[RENAME] : TypeInfo -> BookmarkTypeInfo
kth1210 958471e
[REFACTOR] : BookmarkVM ReactorKit - Reactor 적용
kth1210 d7b1335
[REFACTOR] : BookmarkVC ReactorKit - View 적용
kth1210 dd07db4
[CHORE] : AuthInterceptor 스레드 문제 해결
kth1210 5fb18f5
[REFACTOR] : BookmarkVM ReactorKit - Reactor 적용
kth1210 5f667a4
[REFACTOR] : BookmarkVC ReactorKit - View 적용
kth1210 c9c52cc
[REFACTOR] : BookmarkCardListVM ReactorKit - Reactor 적용
kth1210 078a1a3
[REFACTOR] : BookmarkListVC ReactorKit - View 적용
kth1210 21f74a6
[FEAT] : BookmarkInfo Model empty 추가
kth1210 08bbe18
[REFACTOR] : BookmarkBottomSheetVM ReactorKit - Reactor 적용
kth1210 0a89c8e
[REFACTOR] : BookmarkBottomSheetVC ReactorKit - View 적용
kth1210 86a5583
[CHORE] : BookmarkCardListVM private 키워드 수정
kth1210 384a13f
[CHORE] : 프로젝트 파일 변경 사항 반영
kth1210 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 이 disposeBag이 하는 역할이 있나요?? .init()으로 표현한 이유가 있을까요! (Reactor로 변화를 주다보니 기존에 사용하던 MVVM 패턴에서의 개념과 어느정도 조화를 이루는지 아직 감을 잘 못 잡고 있는 것 같습니다..ㅎ)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마찬가지로 ReactorKit의
View
를 채택하게 되면Reactor
와의 bind를 위해 disposeBag을 가져야 합니다!.init()
은 타입 어노테이션을 해줬기 때문에 편의상 사용했어용