Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[System] DialogScreen 고도화 #8

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[System] DialogScreen 고도화 #8

merged 1 commit into from
Jan 23, 2024

Conversation

ajou4095
Copy link
Collaborator

설명

  • DialogScreen 의 형식을 고정했습니다.
  • DialogScreen 의 State 를 외부에서 관리하도록 수정했습니다.
  • Preview 를 추가했습니다.

참고

체크리스트

  • : 빌드 테스트를 진행하셨나요?
  • : 실제 기기에서 테스트를 진행하셨나요?

@ajou4095 ajou4095 requested a review from jinuemong as a code owner January 23, 2024 16:17
jinuemong
jinuemong approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@jinuemong jinuemong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ajou4095 ajou4095 merged commit 26ce0bc into main Jan 23, 2024
1 check failed
@ajou4095 ajou4095 deleted the system-#7 branch January 23, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinuemong jinuemong jinuemong approved these changes

Assignees
No one assigned
Labels
priority: medium state: in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajou4095 @jinuemong