[Feature] Get 그룹 UI 로직 구현 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajou4095
approved these changes
Feb 5, 2024
Comment on lines
62
to
69
| fun GetGroupScreen( | ||
| onDismissRequest: () -> Unit, | ||
| onResult: (Group) -> Unit, | ||
| model: GetGroupModel, | ||
| handler: CoroutineExceptionHandler, | ||
| intent: (GetGroupIntent) -> Unit, | ||
| event: EventFlow<GetGroupEvent> | ||
| ) { |
There was a problem hiding this comment.
이거 이렇게 하면 ViewModel 이랑 연결이 안돼서 실행을 못할텐데, 기존에 있는 BottomSheet 들 참고해서 연결하는 부분까지 만들어주시고 해당 부분 private 로 만들어주세요.
ajou4095
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명
참고
체크리스트