Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Setting] Error Message 처리 고도화 #44

Merged
merged 2 commits into from
Feb 4, 2024
Merged

[Setting] Error Message 처리 고도화 #44

merged 2 commits into from
Feb 4, 2024

Conversation

ajou4095
Copy link
Collaborator

@ajou4095 ajou4095 commented Feb 4, 2024

설명

  • Error 를 BaseViewModel 에서 세 종류로 나눠서 처리하도록 했습니다.
  • 별도 처리가 필요한 경우에서는 기존과 같이 event 를 이용해, 그렇지 않은 경우 _errorEvent.emit 을 이용해주세요.

참고

체크리스트

  • : 빌드 테스트를 진행하셨나요?
  • : 실제 기기에서 테스트를 진행하셨나요?

@ajou4095 ajou4095 requested a review from jinuemong as a code owner February 4, 2024 15:02
Base automatically changed from setting-#43 to main February 4, 2024 15:47
jinuemong
jinuemong approved these changes Feb 4, 2024
View reviewed changes
Copy link
Collaborator

@jinuemong jinuemong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다 봤습니다.
사용해보고 궁금한점 생기면 질문 드리겠습니다🙇‍♂️

@ajou4095 ajou4095 merged commit d327411 into main Feb 4, 2024
1 check passed
@ajou4095 ajou4095 deleted the setting-#44 branch February 4, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinuemong jinuemong jinuemong approved these changes

Assignees
No one assigned
Labels
develop: refactoring priority: high state: in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajou4095 @jinuemong