Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Setting]: 금액 입력 텍스트 필드 구현 #35

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Conversation

jinuemong
Copy link
Collaborator

설명

  • 금액 입력 텍스트 필드 구현하였씁니다.
  • 버튼으로 금액 추가, 텍스트필드로 입력, 버튼 클릭 시 색상 변경

참고

  • 입력 시 (커서는 캡처에 안보이네용)
    스크린샷 2024-02-03 오후 3 56 24
  • 프리뷰
    스크린샷 2024-02-03 오후 3 56 42

체크리스트

  • : 빌드 테스트를 진행하셨나요?
  • : 실제 기기에서 테스트를 진행하셨나요?

Copy link
Collaborator

@ajou4095 ajou4095 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines 70 to 72
val numberCommaTransFormation = remember { NumberCommaTransformation() }
val textFormat =
if (textValue.isEmpty()) VisualTransformation.None else numberCommaTransFormation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 로직 안에서 처리하셔야 할 것 같아요

NumberCommaTransformation 안에서 text 가 빌 때 뒤에 안붙이면, remember 빼도 되지 않을까 싶어요

Copy link
Collaborator

@ajou4095 ajou4095 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jinuemong jinuemong merged commit f4bac27 into main Feb 3, 2024
1 check passed
@jinuemong jinuemong deleted the setting-#34 branch February 3, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants