Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[System] ConfirmButton 디자인시스템 적용 #26

Merged
merged 4 commits into from
Jan 28, 2024
Merged

[System] ConfirmButton 디자인시스템 적용 #26

merged 4 commits into from
Jan 28, 2024

Conversation

ajou4095
Copy link
Collaborator

@ajou4095 ajou4095 commented Jan 28, 2024 •
edited
Loading

설명

  • ConfirmButton 디자인시스템 적용했습니다.
  • 조립 가능하도록 content 열었습니다.

사용법 수정하게 된 이유 :
image
조립이 불가능할 경우, 위와 같은 상황이 생길 때마다 컴포넌트를 수정해야함 = 변경에 닫혀있음

참고

image

체크리스트

  • : 빌드 테스트를 진행하셨나요?
  • : 실제 기기에서 테스트를 진행하셨나요?

@ajou4095 ajou4095 requested a review from jinuemong as a code owner January 28, 2024 16:10
jinuemong
jinuemong approved these changes Jan 28, 2024
View reviewed changes
Copy link
Collaborator

@jinuemong jinuemong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다봤습니더 🙇‍♂️

@ajou4095 ajou4095 merged commit 21e97a0 into main Jan 28, 2024
1 check passed
@ajou4095 ajou4095 deleted the system-#26 branch January 28, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinuemong jinuemong jinuemong approved these changes

Assignees
No one assigned
Labels
priority: high state: in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajou4095 @jinuemong