[Feature] LoginScreen UI 로직 구현 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajou4095
approved these changes
Jan 27, 2024
...main/kotlin/ac/dnd/bookkeeping/android/presentation/ui/main/login/main/LoginMainViewModel.kt
Outdated
Show resolved
Hide resolved
ajou4095
approved these changes
Jan 28, 2024
| import kotlinx.parcelize.Parcelize | ||
|
|
||
| @Parcelize | ||
| data class KakaoUserInformationModel( |
There was a problem hiding this comment.
default value 여기 적으면 mapping 할 때 빠트리기 쉬워요 (경험담)
| fontSize = 20.sp, | ||
| color = Color.White, | ||
| modifier = Modifier.align(Alignment.Center) | ||
| text = "서비스 이름", |
...main/kotlin/ac/dnd/bookkeeping/android/presentation/ui/main/login/main/LoginMainViewModel.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private fun loginKakao() = launch { | ||
| loginKakaoUseCase.invoke() |
| // TODO : Implement Success Case | ||
| // TODO : Check user is New ? | ||
| // isNew True -> navigateToOnBoarding() + with kakaoUserInfoModel | ||
| // isNew False -> navigateToHome() | ||
| } | ||
|
|
||
| is LoginMainEvent.Login.Error -> { |
There was a problem hiding this comment.
에러에 모달 띄우기로 고고
카카오 로그인에 실패했다고 대충 적으면 될듯
Comment on lines
94
to
109
| private fun submitError(error: Throwable) = launch { | ||
| _event.emit(LoginMainEvent.Login.Error(error)) | ||
| _state.emit(LoginMainState.Init) | ||
| } |
There was a problem hiding this comment.
Fail 이랑 Error 의 차이
Fail : 사용자의 잘못
Error : 사용자와 무관하게 오류
이부분 고려된거 맞을까요?
There was a problem hiding this comment.
! 사용자가 로그인을 취소한 경우를 빼먹었네요
고려하겠습니다
jinuemong
added a commit
that referenced
this pull request
Jan 29, 2024
jinuemong
added
state: in review
state: in progress
and removed
state: in progress
state: in review
labels
ajou4095
approved these changes
Jan 29, 2024
| private fun NavHostController.sendKakaoUserModel(kakaoUserModel: KakaoUserInformationModel) { | ||
| currentBackStackEntry?.savedStateHandle?.apply { | ||
| set( | ||
| "kakaoUserModel", |
There was a problem hiding this comment.
이거는 LoginOnBoardingConstant 에 추가해서 연결해주세요
| @@ -101,6 +144,47 @@ fun LoginMainScreen( | |||
| } | |||
| } | |||
|
|
|||
| @Composable | |||
| private fun SampleComponent() { | |||
There was a problem hiding this comment.
요거 디자인 수정 있을거라하셔서
일단 위치만 그려서 넣었습니다
디테일할 때 image로 넣으려구용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명
참고
체크리스트