Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] 오류 & 최종 디자인 수정 #134

Merged
merged 14 commits into from
Mar 10, 2024
Merged

[Fix] 오류 & 최종 디자인 수정 #134

merged 14 commits into from
Mar 10, 2024

Conversation

jinuemong
Copy link
Collaborator

설명

  • 이미지 등록 오류 제외하고 모든 오류 & 디자인 수정했습니다

참고

체크리스트

  • : 빌드 테스트를 진행하셨나요?
  • : 실제 기기에서 테스트를 진행하셨나요?

var selectedEventId by remember { mutableLongStateOf(-1) }
var memoText by remember { mutableStateOf("") }
var isContinuousState by rememberSaveable { mutableStateOf(false) }
var historyTypeState by rememberSaveable { mutableStateOf(HistoryRegistrationType.TAKE) }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 enum 이라 bundle 에 못넣어요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HistoryRegistrationType요??
이거 잘 저장되는거 같은데 다른 문제가 있나요

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다시 찾아보니 enum 은 Serializable 이네요
https://developer.android.com/reference/kotlin/java/lang/Enum
문제 없을 것 같습니다

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 LocalDate를 bundle에 넣으려면 년월일 나눠서 array로 저장하는게 최선인가요?


var isViewUnRecordMessage by remember { mutableStateOf("") }
var isViewUnRecordMessage by rememberSaveable { mutableStateOf("") }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

필요한 것만 saveable 하게 만들어주세요

fun navigateToOnBoarding(kakaoUserModel: KakaoUserInformationModel) {
appState.navController.sendKakaoUserModel(kakaoUserModel)
}

fun navigateToHome() {
appState.navController.navigate(HomeConstant.ROUTE) {
appState.navController.navigate(HomeConstant.ROUTE_STRUCTURE) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의도된게 맞나요?

@jinuemong jinuemong merged commit 8cee701 into main Mar 10, 2024
1 check passed
@jinuemong jinuemong deleted the fix-#131 branch March 10, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants