[Feature] MA02,MA03,MA03 2차 디자인 QA #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajou4095
approved these changes
Mar 3, 2024
| @@ -168,11 +170,8 @@ private fun HistoryScreen( | |||
| (if (model.unrecordedSchedule.isNotEmpty() && isViewUnrecordedState) 343.dp else 257.dp) | |||
| val swipeState = rememberSwipeableState(initialValue = HistoryViewSwipingType.COLLAPSED) | |||
|
|
|||
| // LaunchedEffect(isDropDownMenuExpanded){ | |||
| // appState.systemUiController.isStatusBarVisible = !isDropDownMenuExpanded | |||
| // } | |||
| LaunchedEffect(swipeState.progress.to, selectedItem, isDropDownMenuExpanded) { | |||
There was a problem hiding this comment.
이거 저렇게 관리하는게 아니라 이부분 (LaunchedEffect) 를 수정해야 할 것 같은데요
백그라운드 / 백스택에서 돌아가는거 막으신거죠?
| ) | ||
| val textLength = relatedHeart.event.length | ||
| val text = | ||
| if (textLength >= 20) relatedHeart.event.substring(0,20).plus("...") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명
참고
체크리스트