Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System] TokenRepository, TokenApi 분리 #103

Merged
merged 4 commits into from
Feb 20, 2024
Merged

[System] TokenRepository, TokenApi 분리 #103

merged 4 commits into from
Feb 20, 2024

Conversation

ajou4095
Copy link
Collaborator

설명

  • Mock -> Real Repository 로 변경했습니다. 이제부터 서버와 연결됩니다.
  • Authentication 에서 Token 을 분리했습니다.
  • 분리한 이유 : AuthenticationRepository - AuthenticationApi - NoAuthKtorHttpModule 순환참조구조
  • 해결 방법 : 공통 부분을 TokenRepository 로 분리해, AuthKtorHttpModule 과 AuthenticationRepository 가 TokenRepository 를 참조하는 방식으로 만들었습니다.

참고

체크리스트

  • : 빌드 테스트를 진행하셨나요?
  • : 실제 기기에서 테스트를 진행하셨나요?

Copy link
Collaborator

@jinuemong jinuemong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from setting-#102 to main February 20, 2024 12:24
@ajou4095
Copy link
Collaborator Author

아 혈압올라 이거왜안됨

@ajou4095
Copy link
Collaborator Author

원인 : Ktor 을 사용하게 되면서, 관련 프로가드 설정이 필요해졌음. 조사 결과 org.slf4j 관련은 dontwarn 으로 처리해도 무관함.

I think it's OK to ignore it because the StaticLoggerBinder class is part of the logger implementation. If a logger implementation dependency is present, e.g., org.slf4j:slf4j-simple:2.0.6, then the warning is absent. Ktor only depends on the interfaces of the SLF4J.

@ajou4095 ajou4095 merged commit f734ca8 into main Feb 20, 2024
1 check passed
@ajou4095 ajou4095 deleted the setting-#103 branch February 20, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants