Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠[Setting] Compose 기본 세팅과 템플릿 제작 #1

Merged
merged 42 commits into from
Jan 19, 2024
Merged

Conversation

jinuemong
Copy link
Collaborator

구현 기능

  • compose관련 기본 세팅과 템플릿을 제작하였습니다.
  • navigation ui를 구현과 sample screen을 적용하였습니다.

특이사항

  • fragment_home.xml의 ConfirmButton에서 에러가 발생하여 임시 주석처리 하였습니다.

@jinuemong jinuemong requested a review from ajou4095 January 17, 2024 17:25
Copy link
Collaborator

@ajou4095 ajou4095 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넣을 때에는 squash해서 넣을텐데, 그 때 커밋명 티켓명에 맞게 설정해서 넣어주세요!
지금은 티켓이 없으니 적당히 적어서 넣어주세요

gradle/libs.versions.toml Outdated Show resolved Hide resolved
}

@Composable
fun SplashScreen(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오, 스플래쉬 화면도 컴포즈로 처리가능하군요!

Copy link
Collaborator

@ajou4095 ajou4095 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOGO

@ajou4095 ajou4095 self-assigned this Jan 18, 2024
@jinuemong jinuemong requested a review from ajou4095 January 19, 2024 04:37
Copy link
Collaborator

@ajou4095 ajou4095 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOGO

Comment on lines +15 to +34
fun navigateToOnBoard(
navController: NavHostController
) {
navController.navigate(LoginRootConstant.LOGIN_ONBOARD) {
popUpTo(LoginRootConstant.LOGIN_MAIN) {
inclusive = true
}
}
}

fun navigateToMain(
navController: NavHostController,
prevRoot: String
) {
navController.navigate(ScreenRootConstant.MAIN_SPLASH) {
popUpTo(prevRoot) {
inclusive = true
}
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드리딩도 할겸 이거 제가 한번 Screen 으로 빼볼게요.

@jinuemong jinuemong merged commit 2042aca into main Jan 19, 2024
1 check passed
@ajou4095 ajou4095 deleted the setting branch January 19, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants