cwljava: refresh with latest schema-salad & proposed CWL v1.2.1 changes #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-c
force-pushed
the
cwljava_update_20220901
branch
from
63b5023 to
79064d8
Compare
|
Okay, so common-workflow-language/cwljava@476b0c0 is a breaking change ; but a necessary change. Can I get some help fixing things here in scala? I checked the "allow edits by maintainers"; or feel free to make a PR to this PR, or your own PR directly |
|
Ping :-) It would be nice to get this merged now, so when CWL v1.3 comes (which is under development and features workflow-level loops), then the upgrade will be easier |
- `Savable` → `Saveable` typo fix changes some class names - `default` field type is now explicitly including `File` and `Directory` alongside `Any` - `hints` is now defined as any of the known requirements, or `Any` (should be a nice simplification) - the refscope for workflow `outputSource` was corrected from 0 to 1
mr-c
force-pushed
the
cwljava_update_20220901
branch
from
79064d8 to
335d3d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Savable→Saveabletypo fix changes some class namesdefaultfield type is now explicitly includingFileandDirectoryalongsideAnyhintsis now defined as any of the known requirements, orAny(should be a nice simplification)outputSourcewas corrected from 0 to 1