Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme color #9

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mahmoud-the-dev
Copy link

@mahmoud-the-dev mahmoud-the-dev commented Oct 19, 2024

I added a list of colors to let the user change the background color.
image

the chosen color is only applied before the yellow timer appear. After that it continues with yellow then red like it used to.

Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
talk-timer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 10:35am

@dnafication
Copy link
Owner

dnafication commented Oct 20, 2024

Hey @mahmoud-the-dev, thanks so much for your contribution! It looks like there might have been a bit of a miscommunication. What I was aiming for is to make the colors and stages configurable. For example, in the settings, it should be possible to add or modify the initial color, then the next one, and so on, with the option to add more than just two stages. Would you be able to explore this approach? Also, I don’t think we need a theme button—the changes can be handled within the settings modal. The goal is to allow configuration of both the colors and the number of timer stages.

@mahmoud-the-dev
Copy link
Author

Okay, I will try again, I just have one question:
should I delete the popover component since it will no longer be used? Or keep it just in case it is needed in the future ?

@dnafication
Copy link
Owner

Thank you so much! Delete the component if it is no longer needed. We can add it back later if needed.

@mahmoud-the-dev
Copy link
Author

Okay great,
I'll push later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants