Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js-jods): Propert support for date-only and time-only in mergeDateAndTime method #653

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

joshkel
Copy link
Contributor

@joshkel joshkel commented Sep 12, 2023

See mui/mui-x#4703 (comment) (although note that mui-x no longer uses date-io).

See mui/mui-x#4703 (comment) (although note that mui-x no longer uses date-io)
@dmtrKovalenko dmtrKovalenko changed the title Add support for date-only and time-only to js-joda fix(js-jods): Propert support for date-only and time-only to js-joda Sep 12, 2023
@dmtrKovalenko dmtrKovalenko changed the title fix(js-jods): Propert support for date-only and time-only to js-joda fix(js-jods): Propert support for date-only and time-only in mergeDateAndTime method Sep 12, 2023
Copy link
Owner

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't let this fix in because it reduces code coverage

@joshkel
Copy link
Contributor Author

joshkel commented Sep 12, 2023

@dmtrKovalenko Fixed. Thanks.

@dmtrKovalenko dmtrKovalenko merged commit 4f78281 into dmtrKovalenko:master Jan 10, 2024
1 check passed
@joshkel joshkel deleted the js-joda-merge-date-time branch January 10, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants