Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update and Delete capabilities for LineItems #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Greyvend
Copy link

@Greyvend Greyvend commented Nov 1, 2023

Hello Dmitry!

First of all, thanks a lot for your implementation of the LTI protocol in Python.

As we've started to adopt the LTI integration in our Tool, we've noticed some of the important LTI documented capabilities missing in the library. One of those is the support for modification and deletion of existing line items. This PR aims to add just that.

What was done in this PR:

  1. Changed the interface of the ServiceConnector.make_service_request method to support other HTTP methods (here).
  2. Added two new methods to the AssignmentsGradesService: update_lineitem, delete_lineitem (here).
  3. Added tests for these methods (here). I've also tested them with a local Canvas instance.

These actions are documented in the LTI page.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant