Allow Netbox to own device/site existence #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,7 +11,7 @@ class Organizer | |||
| end | |||
|
|
|||
| after do | |||
| context.raw_data[:device] = context.device.raw_data! | |||
| context.raw_data[:device] = context.device.raw_data! if context.device | |||
There was a problem hiding this comment.
so the device may be nil if it is not found in the Netbox and devices creation is disabled, right?
Suggested change
| context.raw_data[:device] = context.device.raw_data! if context.device | |
| context.raw_data[:device] = context.device&.raw_data! |
There was a problem hiding this comment.
Did it this way to not mess with the cached parameters, since that service uses key existence to decide what data to generate.
app/interactors/foreman_netbox/sync_host/sync_device/sync_site/organizer.rb
Outdated
Show resolved
Hide resolved
Also adds tests for site upsert as well as device creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For us, Netbox is the source of truth in regards to device/site existence, so letting Foreman create or delete those objects would break our inventory. This then adds options for if devices should be created or removed, or only found and updated, as well as expanding the site sync variable to skip orchestration of the site objects themselves.
Tests still need to be updated for it, and I'm not sure if the settings are the best delineation. Maybe deletion - as one example - should also support setting the device status to something like Decommissioning/Offline/Inventory instead, to allow marking the hardware as no longer in use on deletion in Foreman.