Merge pull request #81 from dlindahl/feature/honor-skip-info

Honor skip_info?
dlindahl · Jan 10, 2024 · 4c25eed · 4c25eed
2 parents 23e2ac8 + 52bf8ce
commit 4c25eed
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 5 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
diff --git a/lib/omniauth/strategies/cas.rb b/lib/omniauth/strategies/cas.rb
@@ -65,9 +65,11 @@ class InvalidCASTicket < StandardError; end
       end
 
       extra do
-        prune!(
-          raw_info.delete_if { |k, _v| AUTH_HASH_SCHEMA_KEYS.include?(k) }
-        )
+        if skip_info?
+          {}
+        else
+          prune!(raw_info.dup.delete_if { |k, _v| AUTH_HASH_SCHEMA_KEYS.include?(k) })
+        end
       end
 
       uid do

diff --git a/spec/omniauth/strategies/cas_spec.rb b/spec/omniauth/strategies/cas_spec.rb
@@ -203,6 +203,26 @@
               expect(subject.hire_date).to eq '2004-07-13'
               expect(subject.roles).to eq %w[senator lobbyist financier]
             end
+
+            context 'when skip_info? is specified' do
+              let(:app) do
+                Rack::Builder.new do
+                  use OmniAuth::Test::PhonySession
+                  use MyCasProvider,
+                      name: :cas,
+                      host: 'cas.example.org',
+                      ssl: false,
+                      port: 8080,
+                      uid_field: :employeeid,
+                      skip_info: true
+                  run ->(env) { [404, { 'Content-Type' => 'text/plain' }, [env.key?('omniauth.auth').to_s]] }
+                end.to_app
+              end
+
+              it 'does not include additional user attributes' do
+                expect(subject).to be_empty
+              end
+            end
           end
 
           context 'the credentials hash' do