Skip to content

Commit

Permalink
Use SCREAMING_SNAKE_CASE for constant name
Browse files Browse the repository at this point in the history
Potential breaking change
  • Loading branch information
tagliala committed Jan 9, 2024
1 parent 0af84ee commit 240ab1e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 0 additions & 4 deletions .rubocop_todo.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions lib/omniauth/strategies/cas.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class InvalidCASTicket < StandardError; end
option :phone_key, 'phone'

# As required by https://github.com/intridea/omniauth/wiki/Auth-Hash-Schema
AuthHashSchemaKeys = %w[name email nickname first_name last_name location image phone].freeze
AUTH_HASH_SCHEMA_KEYS = %w[name email nickname first_name last_name location image phone].freeze
info do
prune!({
name: raw_info[options[:name_key].to_s],
Expand All @@ -66,7 +66,7 @@ class InvalidCASTicket < StandardError; end

extra do
prune!(
raw_info.delete_if { |k, _v| AuthHashSchemaKeys.include?(k) }
raw_info.delete_if { |k, _v| AUTH_HASH_SCHEMA_KEYS.include?(k) }
)
end

Expand Down

0 comments on commit 240ab1e

Please sign in to comment.