Added thumbnail to MagickImage #183
Conversation
| import { MagickGeometry } from '@src/types/magick-geometry'; | ||
| import { TestImages } from '@test/test-images'; | ||
|
|
||
| describe('MagickImage#thumbnail', () => { |
There was a problem hiding this comment.
I think we also need an extra test that makes sure that the some of the metadata is not available in the resulting image.
There was a problem hiding this comment.
I added a test for that! FYI Magick.NET is also missing this test.
There was a problem hiding this comment.
It seems EXIF attributes (so .getAttribute, not .getProfile) are not removed, also not by .strip(). Is this intended behaviour?
There was a problem hiding this comment.
I try not to look at the Magick.NET tests and just add here what I think that should be added. Those attributes are not removed because they will not be stored to file. Maybe to make sure this is working correctly we could save the thumbnail to a blob and then read it again but I don't know if we really need to do that.
Peeterush
force-pushed
the
add-thumbnail
branch
from
51f3879
to
ba56b50
Compare
No description provided.