Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add await to async_forward_entry_setup #156

Closed
wants to merge 2 commits into from
Closed

add await to async_forward_entry_setup #156

wants to merge 2 commits into from

Conversation

bmos
Copy link

@bmos bmos commented Jul 15, 2024

working on a fix for #152

I haven't tested this yet.

@bmos bmos marked this pull request as ready for review July 15, 2024 12:13
@dlarrick
Copy link
Owner

Thanks. I should be able to take a look this coming weekend.

@dlarrick
Copy link
Owner

Hmmm... components that ship with HA seem to use a different pattern, just:

await hass.config_entries.async_forward_entry_setups(entry, PLATFORMS)

.... not even looping over the platforms. Just picking one at random:
https://github.com/home-assistant/core/blob/dev/homeassistant/components/aemet/__init__.py#L54

@dlarrick
Copy link
Owner

Yeah... note the new call is _setups (plural). This works and gets rid of the deprecation warning. Thanks for this PR, but I'm going to close it and include the above fix in my own PR.

@dlarrick dlarrick closed this Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants