D std::map bindings using the wrapper method #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 17, 2024 14:42
some functions like insert_or_assign does not work when not compiled to c++17 they were introduced in that stabdard and it is a cool target standard for D"
add opIndexAssign test
private static fileds are mangled as C and public static fields are mangled as S on MSVC. since fields with no access modifeiers in C++ classes are private by default, it affects the mangling of the fields on windows so need for public there also fields that are private on the D side should match on C++ side. Posix doesn't really care about those but msvc does. match private with private for msvc
Emmankoko
force-pushed
the
map
branch
2 times, most recently
from
1824ea1 to
4eb9cac
Compare
|
I see what this is doing, and it would work great in a project trying to use |
haha true. I'll handle that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrapper method was decided to be used for std::map because macOS symbol generation with template instantiations is largely inconsistent and affects the stability of the module on CppRuntimeClang.
This is an initial show of the complete setup of how it will be distributed as a package. more symbols will be added but I want the initial work to be very clear for easy review.