ADDING MORE TEST FOR std::string ON ALL PLATFORMS #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geod24
reviewed
Feb 11, 2024
source/stdcpp/test/string.d
Outdated
Comment on lines
31
to
34
| auto b = std_string("Hi, this is a test for string capacity growth for a length more than the base SSO"); | ||
| assert(b.capacity == stringCapacity("Hi, this is a test for string capacity growth for a length more than the base SSO")); | ||
| a.swap(b); // a and b swaps | ||
| assert(a.capacity == stringCapacity("Hi, this is a test for string capacity growth for a length more than the base SSO")); |
There was a problem hiding this comment.
Suggested change
| auto b = std_string("Hi, this is a test for string capacity growth for a length more than the base SSO"); | |
| assert(b.capacity == stringCapacity("Hi, this is a test for string capacity growth for a length more than the base SSO")); | |
| a.swap(b); // a and b swaps | |
| assert(a.capacity == stringCapacity("Hi, this is a test for string capacity growth for a length more than the base SSO")); | |
| immutable LongStr = "Hi, this is a test for string capacity growth for a length more than the base SSO"; | |
| auto b = std_string(LongStr); | |
| assert(b.capacity == stringCapacity(LongStr.ptr)); | |
| a.swap(b); // a and b swaps | |
| assert(a.capacity == stringCapacity(LongStr.ptr)); |
Geod24
reviewed
Feb 11, 2024
source/stdcpp/test/string.d
Outdated
| assert(a.empty == 0); | ||
| a.clear(); | ||
| assert(a.empty == 1); | ||
|
|
There was a problem hiding this comment.
why? Unecessary?
There was a problem hiding this comment.
Yes, why would you have trailing whitespace ?
Emmankoko
force-pushed
the
github-actions
branch
from
25167bd to
4be1786
Compare
Geod24
force-pushed
the
github-actions
branch
from
4be1786 to
4298bcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.