Move prepare, lowerNonArrayAggregate and lowerArrayAggregate methods to statementsem

[dchidindu5]

Is there a need to update frontend.h or? @thewilsonator

[dlang-bot]

Thanks for your pull request and interest in making D better, @dchidindu5! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17011"

[thewilsonator]

No, they are all private (and most of them are extern(D)

[thewilsonator]

Also did you mean to close this?

[dchidindu5]

Also did you mean to close this?

I'll reopen it.

[dchidindu5]

Just saw this from the test suite @thewilsonator

 fail_compilation/test21939.d(11): Error: invalid `;` aggregate `Object` of type `Object`
  fail_compilation/test21939.d(11):        `foreach` works with input ranges (implementing `front` and `popFront`), aggregates implementing `opApply`, or the result of an aggregate's `.tupleof` property

[thewilsonator]

That looks like you messed up the token passed to en error somewhere, but it is very strange that it only happens on a few platforms. Will take a look tomorrow.

[dchidindu5]

That looks like you messed up the token passed to en error somewhere, but it is very strange that it only happens on a few platforms. Will take a look tomorrow.

@thewilsonator I would move the methods one by one and see where the problem is from.