Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dataprep fcl generation work for all (or most) prototypes #2

Open
dladams opened this issue Jun 8, 2022 · 2 comments
Open

Make dataprep fcl generation work for all (or most) prototypes #2

dladams opened this issue Jun 8, 2022 · 2 comments
Assignees

Comments

@dladams
Copy link
Owner

dladams commented Jun 8, 2022

The duneproc command provides fcl key dptools_XXX to allow users to select the dataprep sequence at run time but this does not work for all prototypes because the syntax for referencing a sequence varies. DUNE/dunedataprep#2 addresses the latter. Once this is in place this key or another should be made to work with all conformant sequences.

@dladams
Copy link
Owner Author

dladams commented Jun 9, 2022

Last push resolves this issue. (Comment should be "Add duneproc key...")

@dladams
Copy link
Owner Author

dladams commented Jun 9, 2022

I am modifying duneproc to drop the dptools fcl key (i.e. support for pattern dptools_XXX) and replace it
with a dpseq key with pattern

dpseq_<DET>_<SEQ>

that selects sequence <SEQ> for prototype detector <DET>, i.e. with the convention described in DUNE/dunedataprep#2, i.e. matches the pattern

data.<DET>_dataprep_seqs.<SEQ>

In addition, the dunedataprep file pdsp_data_sequences is added to run_dataprep.fcl so the pdsp sequence definitions are available when duneproc processes pdsp data.

Changes are committed in version 2.4.0 of duneproc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant