Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate and fix examples in tutorial 2 #3

Closed
dladams opened this issue Jun 8, 2022 · 7 comments
Closed

Validate and fix examples in tutorial 2 #3

dladams opened this issue Jun 8, 2022 · 7 comments

Comments

@dladams
Copy link
Owner

dladams commented Jun 8, 2022

I am working to validate and fix the examples in tutorial 2.

@dladams
Copy link
Owner Author

dladams commented Jun 9, 2022

Example 11 demonstrates using the dptools fcl key to run a standard dataprep sequence but doesn't work. It appears the problem is that the generator is using the pattern

data.dataprep_seqs.$VAL

while the pdsp proglog (protodune_dataprep_services.fcl) actually uses prolog

protodune_dataprep_tools_calib_only

which does not match the above.

This could be fixed but still leaves a pattern that will only work for the one prototype. Issue #2 has been created to modify or replace this key to work for all or most prototypes. Once that is done the example 11 will be updated accordingly.

@dladams
Copy link
Owner Author

dladams commented Jun 9, 2022

Example 12 has also been updated to use dpseq and is now working.

@dladams
Copy link
Owner Author

dladams commented Jun 9, 2022

I have asked Leigh, Tingjun and Tom for help on example 10 which process MC data.

@dladams
Copy link
Owner Author

dladams commented Jun 9, 2022

Tingjun suggest to try this data file:
PDSPProd4a_protoDUNE_sp_detsim_p1GeV_35ms_sce_datadriven_18800650_32_20210414T012327Z.root

I added it to the example MC dataset defn in duneproc.

@dladams
Copy link
Owner Author

dladams commented Jun 10, 2022

I change the MC dataset mysimdst and added event display fcl and the example now works.

I will keep this open until I verify all examples work in a dunesw release. Rignt now one needs the dunedataprep develop.

@dladams
Copy link
Owner Author

dladams commented Jun 13, 2022

I confirmed examples do not work with dunesw v09_53_00d00. I hope things will be better with v09_54_00d00.

@dladams
Copy link
Owner Author

dladams commented Jul 5, 2022

I have verified that the examples do work with dunesw v09_54_00d00 using dunerun 1.21.00 and duneproc 2.4.1.

@dladams dladams closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant