This repository has been archived by the owner on Sep 27, 2022. It is now read-only.
Kotsyrba Alina 397 JUnit, Storeable, Parallel #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public void drop() { | ||
| for (byte i = 0; i < 16; ++i) { | ||
| for (byte j = 0; j < 16; ++j) { | ||
| File file = new File(getFullName(new DirFile(i, j))); |
There was a problem hiding this comment.
Стоит обернуть этот блок в try catch
|
Вынеси в константы 16, 256, 255, 100. |
|
Используй возможности Java 8 |
| return status; | ||
| } | ||
|
|
||
| public void setStatus(byte newStatus) { |
There was a problem hiding this comment.
Разве он где-то используется?
added 3 commits
December 22, 2014 00:16
| } | ||
|
|
||
| if ((firstName < 0) || firstName > FILES_COUNT - 1) { | ||
| throw new MultiDataBaseException(dataBaseDirectory + " wrong file first name " + dir); |
There was a problem hiding this comment.
Повтор строки. Вынести в константы
|
|
||
| public String put(final String keyStr, final String valueStr) { | ||
| try { | ||
| byte[] key = keyStr.getBytes("UTF-8"); |
There was a problem hiding this comment.
Кодировку вынесите в константы
vpavlenko
changed the title
|
|
||
| @Override | ||
| public int size() { | ||
| int allSize = 0; |
There was a problem hiding this comment.
Вы не хотите здесь взять лок?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.