Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trap EffectType Accepts Names #3698

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Trap EffectType Accepts Names #3698

merged 2 commits into from
Nov 20, 2024

Conversation

walt253
Copy link
Contributor

@walt253 walt253 commented Nov 18, 2024

Still accepts numbers, for both config and script command. Untested.

@walt253 walt253 marked this pull request as ready for review November 18, 2024 20:46
@Loobinex
Copy link
Member

Code looks fine, a tiny bit of testing wouldn't hurt.

@walt253
Copy link
Contributor Author

walt253 commented Nov 20, 2024

@benlp91 and RauelOn confirmed it works well

@Loobinex Loobinex merged commit b63eb6f into dkfans:master Nov 20, 2024
@walt253 walt253 deleted the TrapEffectTypeAcceptsNames branch November 20, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walt253 @Loobinex