Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash with drawing swipe #3662

Closed
wants to merge 5 commits into from
Closed

Fix crash with drawing swipe #3662

wants to merge 5 commits into from

Conversation

walt253
Copy link
Contributor

@walt253 walt253 commented Nov 11, 2024

No description provided.

@walt253 walt253 marked this pull request as ready for review November 11, 2024 15:49
@walt253
maybe best to default it to 1 if it happens
75ec8e3 
units_per_px shouldn't be 0 too
@walt253
Update thing_creature.c
4ba5e01 
no point trying to draw a zero-width sprite
@walt253 walt253 changed the title Fix crash with drawing swipe + fix recents build warnings Fix crash with drawing swipe Nov 13, 2024
@walt253 walt253 marked this pull request as draft November 14, 2024 15:50
@walt253 walt253 marked this pull request as ready for review November 14, 2024 15:50
Loobinex
Loobinex requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@Loobinex Loobinex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it not to work.

@Loobinex
Copy link
Member

To reproduce the crash:

  1. Download and install the halloween mappack
  2. Load this zipfile: fx1g0001.zip
  3. Wait for the ghost to break the door and start battle with the enemies
  4. Pick him up to and drop him elsewhere.
  5. Immediately possess him and left click to do an attack
    -> crash to desktop

@walt253 walt253 marked this pull request as draft November 14, 2024 20:08
@walt253
Copy link
Contributor Author

walt253 commented Nov 14, 2024

I cannot reproduce with this save, doesn't work for me even with the right files (mappack and alpha).

What does your log say now? Still a division by 0 with same function?

@Loobinex
Copy link
Member

I cannot reproduce with this save, doesn't work for me even with the right files (mappack and alpha).

What does your log say now? Still a division by 0 with same function?

Exception 0xc0000005 thrown: EXCEPTION_ACCESS_VIOLATION
Error: Attempt to read from inaccessible memory address.
[#15] keeperfx.exe : draw_swipe_graphic                   [0x5b8340+0x111]	 map lookup for: 0023:002f8451, base: 00140000
[#14] keeperfx.exe : redraw_creature_view                 [0x4c69a0+0x82]	 map lookup for: 0023:00206a22, base: 00140000
[#13] keeperfx.exe : redraw_display                       [0x4c8350+0x5fd]	 map lookup for: 0023:0020894d, base: 00140000
[#12] keeperfx.exe : keeper_screen_redraw                 [0x4c8be0+0x148]	 map lookup for: 0023:00208d28, base: 00140000

@walt253 walt253 closed this Nov 14, 2024
@walt253 walt253 deleted the DrawSwipeCrashFix branch November 14, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loobinex Loobinex Loobinex requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@walt253 @Loobinex