implement interaction #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youbitchoc
force-pushed
the
clickable
branch
from
7129a0b
to
0807301
Compare
sevz17
suggested changes
Sep 24, 2022
it's really scuffed
youbitchoc
force-pushed
the
clickable
branch
from
0807301
to
57da6eb
Compare
sevz17
reviewed
Sep 27, 2022
sevz17
reviewed
Sep 27, 2022
| return; | ||
| if(fork() == 0) { | ||
| setsid(); | ||
| execl(shell, shell, "-c", arg, (char *)NULL); |
There was a problem hiding this comment.
I haven't read the dzen's docs but maybe hardcoding "/bin/sh" is better
sevz17
reviewed
Sep 27, 2022
sevz17
reviewed
Oct 7, 2022
Comment on lines
+411
to
+422
| wl_pointer_enter(void *data, struct wl_pointer *wl_pointer, | ||
| uint32_t serial, struct wl_surface *surface, | ||
| wl_fixed_t surface_x, wl_fixed_t surface_y) | ||
| { | ||
| struct input_state *istate = data; | ||
| istate->surface = surface; | ||
| istate->x = wl_fixed_to_double(surface_x); | ||
| istate->y = wl_fixed_to_double(surface_y); | ||
| } |
There was a problem hiding this comment.
I re-read the protocol, and it says:
When a seat's focus enters a surface, the pointer image
is undefined and a client should respond to this event by setting
an appropriate pointer image with the set_cursor request.
There was a problem hiding this comment.
I think that's better suited for a separate pr
youbitchoc
force-pushed
the
clickable
branch
3 times, most recently
from
170a043
to
b7a63c5
Compare
sevz17
suggested changes
Aug 27, 2023
Comment on lines
+145
to
+149
| struct clickable { | ||
| uint32_t x1, y1, x2, y2; | ||
| uint8_t btn; | ||
| char *cmd; | ||
| }; |
There was a problem hiding this comment.
Please move this after the enum (L38)
Comment on lines
+170
to
+171
| static struct clickable clickies[MAX_CLICKABLES]; | ||
| static int clicky_i = 0; |
There was a problem hiding this comment.
Please move this with the rest of global variables.
Comment on lines
+407
to
+411
| struct input_state { | ||
| struct wl_surface *surface; | ||
| double x, y; | ||
| uint32_t button; | ||
| }; |
There was a problem hiding this comment.
Also move this after the enum, (sort alphabetically)
|
@sevz17 just realized that I have a more updated branch at youbitchoc:interaction, I'll work on fixing these issues there? |
|
Yes, actually send the PR in my repo, I already started to merge PR's there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.