PR for statistic endpoint #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeck1432
requested changes
Oct 24, 2024
web_app/api/user.py
Outdated
| # Return total amounts and unique users count | ||
| return {"total_amounts": total_amounts, "unique_users": unique_users_count} | ||
|
|
||
| except Exception as e: |
There was a problem hiding this comment.
which particular exception your are trying to catch?
djeck1432
requested changes
Oct 25, 2024
web_app/api/serializers/user.py
Outdated
| contract_address: str | None = Field( | ||
| None, | ||
| example="0xabc123...", | ||
| description="The contract address of the user, or None if not deployed.", | ||
| ) | ||
|
|
||
|
|
||
| class GetStats(BaseModel): |
There was a problem hiding this comment.
Model name can start with verb
Change it to StatsData or StatsResponse if it's response model
web_app/api/user.py
Outdated
| # Return total amounts and unique users count | ||
| return {"total_amounts": total_amounts, "unique_users": unique_users_count} | ||
|
|
||
| except Exception as e: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.