Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: centralize background image handling and clean up assets #420

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: centralize background image handling and clean up assets #420

wants to merge 10 commits into from
+211 −237

Conversation

BigBen-7
Copy link

No description provided.

@djeck1432 djeck1432 linked an issue Dec 20, 2024 that may be closed by this pull request
[FRONTEND] Consistent Background [desktop/mobile] #418
Open
whateverfw
whateverfw requested changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@whateverfw whateverfw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Individual pages should not have bg files, it should only be set in a wrapper (.App) once - for desktop and mobile.

Remove background from all other .css files, along with image assets that should not be used anymore

@whateverfw
Copy link
Collaborator

whateverfw commented Dec 21, 2024 •
edited
Loading

@BigBen-7 Also please resolve merge conflicts (I believe you can accept all changes from main and then remove background in those css)

@djeck1432
Copy link
Owner

@BigBen-7 Please, resolve conflict

@whateverfw
Copy link
Collaborator

Individual pages should not have bg files, it should only be set in a wrapper (.App) once - for desktop and mobile.

Remove background from all other .css files, along with image assets that should not be used anymore

@BigBen-7 it is still not resolved, I don't see old background files to be removed, and background still exists on page levels

whateverfw
whateverfw requested changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@whateverfw whateverfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make changes according to requirements

whateverfw
whateverfw requested changes Dec 21, 2024
View reviewed changes
frontend/src/globals.css Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whateverfw whateverfw whateverfw requested changes

@djeck1432 djeck1432 Awaiting requested review from djeck1432

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FRONTEND] Consistent Background [desktop/mobile]
3 participants
@BigBen-7 @whateverfw @djeck1432