feat(frontend): add WithdrawAll component and route #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whateverfw
requested changes
Dec 19, 2024
frontend/src/pages/spotnet/dashboard/withdraw-all/WithdrawAll.jsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/spotnet/dashboard/withdraw-all/WithdrawAll.jsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/spotnet/dashboard/withdraw-all/withdraw_all.css
Outdated
Show resolved
Hide resolved
frontend/src/pages/spotnet/dashboard/withdraw-all/WithdrawAll.jsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/spotnet/dashboard/withdraw-all/WithdrawAll.jsx
Outdated
Show resolved
Hide resolved
|
@whateverfw your review comments were addressed! |
whateverfw
requested changes
Dec 20, 2024
There was a problem hiding this comment.
@1nonlypiece In general everything if fine, almost everything is fixed, thanks.
Please fix small issues in unresolved threads
frontend/src/pages/spotnet/dashboard/withdraw-all/WithdrawAll.jsx
Outdated
Show resolved
Hide resolved
|
@1nonlypiece Any updates? |
|
@djeck1432 will address it soon |
|
@1nonlypiece please sync with main |
|
Done @whateverfw |
whateverfw
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Withdraw-All Page Implementation
Overview
This PR introduces the implementation of the
Withdraw Allpage, enabling users to close all positions and withdraw all tokens to their wallet. The page includes integration with the backend API and aligns the UI with the provided Figma design.Closes #405
Key Changes
WithdrawAll Component
WithdrawAllcomponent located atpages/spotnet/dashboard/withdraw-all/WithdrawAll.jsx.Withdraw Allbutton with the backend endpointGET /api/withdraw-allusing thewallet_idparameter.Routing
Withdraw Allpage inApp.jsx:UI Enhancements
withdraw_all.cssto align the design with the Figma specifications.Global Changes
globals.cssfor consistent UI styling across the application.form.cssto address mismatches between the existing UI and the Figma design.Error Messaging
AlertHexagon) to display user-friendly error messages.Testing
Withdraw Allbutton successfully interacts with the API and processes the response.Screenshots/Video
Attached is a video showcasing the new
Withdraw Allpage UI and functionality.https://www.loom.com/share/ec97640df87c4d1e854e62e28fcab8b0?sid=852e6f8b-48e5-481d-a963-c27e730dfff9